Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework experiment table context menus to vary based on whether or not experiments have checkpoints #1739

Merged
merged 3 commits into from
May 19, 2022

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented May 19, 2022

2/2 main <- #1738 <- this

This PR follows up from #1738 by making the same changes to our experiments table context menus. The reason for the split is how large the previous PR was and how many files this one touches.

Checkpoints

image

No checkpoints

image

Closes #1711

@mattseddon mattseddon added the product PR that affects product label May 19, 2022
@mattseddon mattseddon self-assigned this May 19, 2022
@mattseddon mattseddon changed the base branch from main to experiment-context-menus May 19, 2022 06:01
@mattseddon mattseddon changed the base branch from experiment-context-menus to main May 19, 2022 06:02
@mattseddon mattseddon marked this pull request as ready for review May 19, 2022 06:17
@mattseddon mattseddon requested review from shcheklein and a team May 19, 2022 06:17
@mattseddon mattseddon changed the base branch from main to experiment-context-menus May 19, 2022 07:19
Copy link
Contributor

@rogermparent rogermparent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

projectHasCheckpoints may be a good candidate for being part of some sort of Context implementation (React.Context, Redux, or otherwise) in the future.

@mattseddon mattseddon force-pushed the exp-webview-context-menus branch from 0502f29 to 0c95dd5 Compare May 19, 2022 22:11
Base automatically changed from experiment-context-menus to main May 19, 2022 22:19
@mattseddon mattseddon force-pushed the exp-webview-context-menus branch from 0c95dd5 to d2ce25d Compare May 19, 2022 22:22
@mattseddon mattseddon enabled auto-merge (squash) May 19, 2022 22:23
@codeclimate
Copy link

codeclimate bot commented May 19, 2022

Code Climate has analyzed commit d2ce25d and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.8%.

View more on Code Climate.

@mattseddon mattseddon merged commit cef7e89 into main May 19, 2022
@mattseddon mattseddon deleted the exp-webview-context-menus branch May 19, 2022 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR that affects product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Experiments side panel - add reset / reset and run action
3 participants