Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make deeply nested experiments table test fixture static #1745

Merged
merged 3 commits into from
May 20, 2022

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented May 20, 2022

1/2 main <- this <- #1740

As discussed in the retro.

Change is needed for #1740 - #1740 (comment)

@mattseddon mattseddon self-assigned this May 20, 2022
@mattseddon mattseddon marked this pull request as ready for review May 20, 2022 01:05
@@ -2,7 +2,6 @@
import { join } from 'dvc/src/test/util/path'
import { ColumnGroup } from 'react-table'
import { Experiment, ColumnType } from 'dvc/src/experiments/webview/contract'
import { collectColumns } from 'dvc/src/experiments/columns/collect'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤌

@mattseddon mattseddon enabled auto-merge (squash) May 20, 2022 19:01
@codeclimate
Copy link

codeclimate bot commented May 20, 2022

Code Climate has analyzed commit ee852f4 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.8% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit 50b8243 into main May 20, 2022
@mattseddon mattseddon deleted the make-test-fixture-static branch May 20, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants