Mitigate Python extension rejecting ready promise #1765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
force-pushed
the
mitigate-ready-reject
branch
from
83819ea to
c3c2ab4
Compare
rogermparent
approved these changes
May 25, 2022
mattseddon
force-pushed
the
mitigate-ready-reject
branch
from
c3c2ab4 to
737fb16
Compare
|
I'm going to merge and ship this so it can be tested tomorrow 👍🏻 . |
|
Code Climate has analyzed commit 737fb16 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.8% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was first surfaced by @rogermparent in #1318.
I've raised this PR due to the behaviour demonstrated by @dacbd in this video.
My working theory is that some part of the Python extension fails to load correctly in a SSH session and the ready promise gets rejected. Hopefully, this will be mitigated by the solution Roger proposed above.