Make params and metrics colors more light-theme friendly #1773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogermparent
added
🎨 design
sroy3
approved these changes
May 25, 2022
mattseddon
reviewed
May 25, 2022
extension/package.json
Outdated
| "dark": "#fbd38d", | ||
| "light": "#fbd38d" | ||
| "dark": "charts.yellow", | ||
| "light": "charts.yellow" |
There was a problem hiding this comment.
I'd rather pick two different default colors as I intend to use these as colors for experiments when we make the switch from custom svgs to theme colors.
There was a problem hiding this comment.
Understood, I changed to the alternate static implementation described in the OP.
rogermparent
changed the title
mattseddon
approved these changes
May 26, 2022
|
Code Climate has analyzed commit dd90d65 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.8% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR usescharts.yellowandcharts.bluefor params and metrics on the experiments table. When I was recording a feature video, I noticed that the current static colors, while still readable, don't work well on most light themes. As such, I tried this out and found that the charts colors do better in this regard (though they look markedly less appealing on some themes, namely my boy Kimbie Dark).This PR adds different
lightdefault values for our Params and Metrics header colors. Previously it usedcharts.yellowandcharts.blue, but those are slated for other uses in the future.The colors I chose are simply the dark mode colors, but with the value inverted (100% - darkvalue% = lightvalue%)
Before:
non-charts-colors-demo.mp4
After:
light-theme-friendly-static-colors-demo.mp4