Switch list-selection icon to list-filter #1800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure I got the difference tbh, can you clarify a bit Matt? |
|
Code Climate has analyzed commit 247b23b and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.8% (0.0% change). View more on Code Climate. |
|
Previously we used this icon in the
We are now going to use this icon as that was the icon selected to symbolise a list filter in the plots webview:
BeforeScreen.Recording.2022-05-31.at.9.48.57.am.movAfterScreen.Recording.2022-05-31.at.9.48.23.am.mov |
|
thanks @mattseddon ! |
shcheklein
approved these changes
May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces our use of the
list-selectionicon in the view container trees with thelist-filtericon which will be used in the plots ribbon (#1798).