Use vscode tree.tableColumnsBorder to add contrast in light themes #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
reviewed
May 31, 2022
| @@ -12,6 +12,7 @@ $row-bg-color: $bg-color; | |||
| $header-fg-color: $fg-color; | |||
| $row-bg-alt-color: var(--vscode-sideBar-background); | |||
| $header-bg-color: var(--vscode-dropdown-background); | |||
| $header-border-color: var(--vscode-tree-tableColumnsBorder); | |||
There was a problem hiding this comment.
[I] Need to add a value for this to webview/src/stories/test-vscode-styles.scss so that it appears in the storybook.
|
We probably want to drop the second line between the header and the rest of the table too:
|
sroy3
approved these changes
May 31, 2022
wolmir
force-pushed
the
exp-table-fix-light-theme-contrast
branch
from
69c8c91 to
aa171c5
Compare
mattseddon
approved these changes
Jun 2, 2022
|
Code Climate has analyzed commit 6b4626f and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.8% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1787
This PR uses VSCode's built-in
tree.tableColumnsBorderfor the experiments table header borders in order to add more contrast in light themes.