Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use copy button component for the plots ribbon experiments #1812

Merged
merged 21 commits into from
Jun 3, 2022

Conversation

sroy3
Copy link
Contributor

@sroy3 sroy3 commented Jun 1, 2022

Screen.Recording.2022-06-01.at.10.52.07.AM.mov

Stephanie Roy and others added 15 commits May 27, 2022 14:48

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@sroy3 sroy3 added the product PR that affects product label Jun 1, 2022
@sroy3 sroy3 self-assigned this Jun 1, 2022
@sroy3 sroy3 changed the base branch from main to plots-ribbon-add-exp June 1, 2022 14:50
@sroy3 sroy3 marked this pull request as ready for review June 1, 2022 14:53
@sroy3 sroy3 marked this pull request as draft June 1, 2022 14:54
@sroy3 sroy3 marked this pull request as ready for review June 1, 2022 14:59
Copy link
Contributor

@rogermparent rogermparent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works for me on a manual test!

I do think the buttons appearing to the side and reflowing the ribbon is a bit jarring, maybe a better looking solution would be to have the ribbon item expand downward on hover to reveal the control buttons? Either way, I think this is a fine inclusion as is.

Base automatically changed from plots-ribbon-add-exp to main June 2, 2022 15:22

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Stephanie Roy and others added 2 commits June 2, 2022 11:51

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
mattseddon and others added 2 commits June 3, 2022 08:30

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@sroy3 sroy3 enabled auto-merge (squash) June 3, 2022 14:15
@codeclimate
Copy link

codeclimate bot commented Jun 3, 2022

Code Climate has analyzed commit 2056da7 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.9% (0.1% change).

View more on Code Climate.

@sroy3 sroy3 merged commit e2804bb into main Jun 3, 2022
@sroy3 sroy3 deleted the plots-ribbon-copy-button branch June 3, 2022 14:19
@maxagin maxagin self-assigned this Jun 3, 2022
@maxagin maxagin added the 🎨 design Needs design input or is being actively worked on label Jun 3, 2022
@shcheklein
Copy link
Member

Thanks, @sroy3 . Agreed with Roger that we should show icon to the right in this case (truncate name if needed). (or some other way to handle this)

@sroy3
Copy link
Contributor Author

sroy3 commented Jun 3, 2022

Thanks, @sroy3 . Agreed with Roger that we should show icon to the right in this case (truncate name if needed). (or some other way to handle this)

I'll follow up on this

@maxagin
Copy link
Contributor

maxagin commented Jun 4, 2022

Looks good @sroy3! I would just mack sure the single block won't change its and parent container widths, so the user won't experience unnecessary movement, but just icon will be shown. WDYT?

@maxagin maxagin removed their assignment Jun 4, 2022
@sroy3
Copy link
Contributor Author

sroy3 commented Jun 6, 2022

Looks good @sroy3! I would just mack sure the single block won't change its and parent container widths, so the user won't experience unnecessary movement, but just icon will be shown. WDYT?

Already done in another PR. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 design Needs design input or is being actively worked on product PR that affects product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants