Add support view to DVC container #1817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
commented
Jun 2, 2022
extension/package.json
Outdated
| }, | ||
| { | ||
| "view": "dvc.views.support", | ||
| "contents": "[$(github) Github Issues](https://github.com/iterative/vscode-dvc/issues)\n[$(comment-discussion) Discord](https://discord.com/invite/dvwXA2N)", |
There was a problem hiding this comment.
[F] Discord invite to be updated when we get a new invitation from here.
There was a problem hiding this comment.
[F] Issues link will go to 404 until the repo is open source.
mattseddon
requested review from
sroy3,
maxagin,
rogermparent,
shcheklein and
wolmir
|
Looks cool, thanks @mattseddon ! |
shcheklein
approved these changes
Jun 2, 2022
sroy3
approved these changes
Jun 2, 2022
|
Code Climate has analyzed commit 71040b1 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.8% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This view was in the original design from a long time ago. Seems like a good time to add it now.
Demo
Screen.Recording.2022-06-02.at.4.29.22.pm.mov
Note: As per the demo this view can be minimised by the user.