Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove revision filtering from comparison table icon menu #1823

Merged
merged 3 commits into from
Jun 2, 2022

Conversation

sroy3
Copy link
Contributor

@sroy3 sroy3 commented Jun 2, 2022

We shouldn't need that anymore with the new ribbon. This will make things much simpler for the new state management as well.

@sroy3 sroy3 self-assigned this Jun 2, 2022
@sroy3 sroy3 marked this pull request as ready for review June 2, 2022 19:31
plots={plots}
revisions={revs.filter(rev => selectedPlots.includes(rev.revision))}
/>
<ComparisonTable plots={plots} revisions={revisions} />
) : (
<EmptyState isFullScreen={false}>No Revisions to Show</EmptyState>
Copy link
Member

@mattseddon mattseddon Jun 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[I] I think this can be removed as well as if there are no revisions the whole component will be gone and the "global" empty state will be shown. There might be a related story that we can get rid of too 🎉. 👈🏻 couldn't find one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it in my redux branch and decided it would be better to remove the feature in its own branch and did a poor job of recreating what I had done. Thanks for pointing this out.

Stephanie Roy and others added 2 commits June 2, 2022 15:44

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@sroy3 sroy3 enabled auto-merge (squash) June 2, 2022 19:47
@codeclimate
Copy link

codeclimate bot commented Jun 2, 2022

Code Climate has analyzed commit 67e84af and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.8% (0.0% change).

View more on Code Climate.

@sroy3 sroy3 merged commit dfa3e8d into main Jun 2, 2022
@sroy3 sroy3 deleted the no-comparison-filtering branch June 2, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants