Suppress context menus, hide run buttons and show stop button when an experiment is running #1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
changed the title
mattseddon
changed the title
mattseddon
commented
Jun 7, 2022
| hasCheckpoints | ||
| } = tableData | ||
|
|
||
| const someExperimentsRunning = React.useMemo(() => { |
There was a problem hiding this comment.
[F] Moved this back to the extension as we need it there to set the context value.
mattseddon
force-pushed
the
hide-commands-when-exp-running
branch
from
23ca13c to
cb87090
Compare
sroy3
approved these changes
Jun 7, 2022
rogermparent
approved these changes
Jun 7, 2022
|
Code Climate has analyzed commit 111a182 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 97.2% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.9% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1837.
The OP is that running an experiment through the terminal doesn't lead to the expected behaviour.
Description of what is going wrong:
The change to replace
dvc.runnerrunning with a newdvc.experiment.runningcontext value which is based on a combination ofexp showdata and thecliRunnerstatus. If either show an experiment is running then we suppress context menus, hide run buttons and show the stop button.Demo
Screen.Recording.2022-06-07.at.2.47.53.pm.mov
Screen.Recording.2022-06-07.at.2.50.00.pm.mov
Screen.Recording.2022-06-07.at.2.55.16.pm.mov