-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add init to command palette when there is no DVC project in the workspace #1861
Conversation
@@ -601,7 +601,7 @@ | |||
}, | |||
{ | |||
"command": "dvc.init", | |||
"when": "false" | |||
"when": "dvc.commands.available && !dvc.cli.incompatible && !dvc.project.available" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[F] Matches the welcome view when:
{
"view": "dvc.views.welcome",
"contents": "The currently open folder does not contain a DVC project. You can initialize a project which will enable features powered by DVC.\n[Initialize Project](command:dvc.init)\nTo learn more about how to use DVC please read [our docs](https://dvc.org/doc).",
"when": "dvc.commands.available && !dvc.cli.incompatible && !dvc.project.available"
},
@@ -20,8 +20,7 @@ | |||
"command.getStarted": "Get Started", | |||
"command.gitStageAll": "Stage All Git Tracked", | |||
"command.gitUnstageAll": "Unstage All Git Tracked", | |||
"command.init": "Init DVC", | |||
"command.initNoScm": "Init DVC --no-scm", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[F] Deleted a long time ago. May bring it back at some point but not now.
[Q] @shcheklein should we try and run |
Not automatically I think. Let's keep it explicit.
let's create a ticket for this pls on the DVC side? |
Code Climate has analyzed commit a64e83b and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.6% (0.0% change). View more on Code Climate. |
* Add width/height: 100% styles in Storybook preview * Add shadow to sticky header * Remove preview marker from marketplace listing (#1860) * Add init to command palette when there is no DVC project in the workspace (#1861) * Upgrade dev dependencies and resolutions (security) (#1864) * Remove div wrapper on header cells and add special exp cell border * Make head and body rows have different background colors * Fix style suppression Co-authored-by: mattseddon <37993418+mattseddon@users.noreply.github.com>
Screenshot