Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add init to command palette when there is no DVC project in the workspace #1861

Merged
merged 2 commits into from
Jun 8, 2022

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Jun 8, 2022

Screenshot

Screen Shot 2022-06-08 at 3 17 33 pm

@mattseddon mattseddon added the product PR that affects product label Jun 8, 2022
@mattseddon mattseddon self-assigned this Jun 8, 2022
@mattseddon mattseddon added 🏠 housekeeping and removed product PR that affects product labels Jun 8, 2022
@@ -601,7 +601,7 @@
},
{
"command": "dvc.init",
"when": "false"
"when": "dvc.commands.available && !dvc.cli.incompatible && !dvc.project.available"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[F] Matches the welcome view when:

      {
        "view": "dvc.views.welcome",
        "contents": "The currently open folder does not contain a DVC project. You can initialize a project which will enable features powered by DVC.\n[Initialize Project](command:dvc.init)\nTo learn more about how to use DVC please read [our docs](https://dvc.org/doc).",
        "when": "dvc.commands.available && !dvc.cli.incompatible && !dvc.project.available"
      },

@@ -20,8 +20,7 @@
"command.getStarted": "Get Started",
"command.gitStageAll": "Stage All Git Tracked",
"command.gitUnstageAll": "Unstage All Git Tracked",
"command.init": "Init DVC",
"command.initNoScm": "Init DVC --no-scm",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[F] Deleted a long time ago. May bring it back at some point but not now.

@mattseddon mattseddon marked this pull request as ready for review June 8, 2022 05:20
@mattseddon
Copy link
Member Author

[Q] @shcheklein should we try and run git init as well if there is no Git repository yet? We also get exp show errors when there has not been a commit.

@mattseddon mattseddon requested a review from shcheklein June 8, 2022 05:36
@shcheklein
Copy link
Member

should we try and run git init as well if there is no Git repository yet

Not automatically I think. Let's keep it explicit.

We also get exp show errors when there has not been a commit.

let's create a ticket for this pls on the DVC side?

@mattseddon mattseddon enabled auto-merge (squash) June 8, 2022 18:39
@codeclimate
Copy link

codeclimate bot commented Jun 8, 2022

Code Climate has analyzed commit a64e83b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.6% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit 6f43e1c into main Jun 8, 2022
@mattseddon mattseddon deleted the add-init-to-command-palette branch June 8, 2022 18:43
rogermparent added a commit that referenced this pull request Jun 10, 2022
* Add width/height: 100% styles in Storybook preview

* Add shadow to sticky header

* Remove preview marker from marketplace listing (#1860)

* Add init to command palette when there is no DVC project in the workspace (#1861)

* Upgrade dev dependencies and resolutions (security) (#1864)

* Remove div wrapper on header cells and add special exp cell border

* Make head and body rows have different background colors

* Fix style suppression

Co-authored-by: mattseddon <37993418+mattseddon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants