Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass extra args to Reset and Run command #1879

Merged
merged 1 commit into from
Jun 13, 2022
Merged

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Jun 13, 2022

This PR fixes a bug where the correct arguments never made it to the reset and run command.

Demo

Screen.Recording.2022-06-13.at.10.09.44.am.mov

@mattseddon mattseddon added the bug Something isn't working label Jun 13, 2022
@mattseddon mattseddon self-assigned this Jun 13, 2022
@mattseddon mattseddon force-pushed the pass-args-to-reset branch from 0c1b789 to 150c58c Compare June 13, 2022 00:13
@mattseddon mattseddon marked this pull request as ready for review June 13, 2022 00:14
@mattseddon mattseddon requested a review from shcheklein June 13, 2022 00:14
@mattseddon mattseddon force-pushed the pass-args-to-reset branch from 150c58c to 6c0e835 Compare June 13, 2022 00:35
@mattseddon mattseddon enabled auto-merge (squash) June 13, 2022 00:35
@codeclimate
Copy link

codeclimate bot commented Jun 13, 2022

Code Climate has analyzed commit 6c0e835 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.6% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit b4c944f into main Jun 13, 2022
@mattseddon mattseddon deleted the pass-args-to-reset branch June 13, 2022 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants