Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap codicons for Reset and Run/Resume experiment #1880

Merged
merged 2 commits into from
Jun 13, 2022
Merged

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Jun 13, 2022

From @shcheklein

When you hit run to my mind it should be running the new one, not resuming
So that run button always does the same - runs a new experiment
And there should be a separate button to resume / continue

Updated "Reset And Run" to use the play codicon and switched "Resume" to use debug-continue-small. Also switched the order wherever they are displayed.

Demo

Screen.Recording.2022-06-13.at.10.37.00.am.mov

@mattseddon mattseddon added the product PR that affects product label Jun 13, 2022
@mattseddon mattseddon self-assigned this Jun 13, 2022
@mattseddon mattseddon marked this pull request as ready for review June 13, 2022 00:40
@mattseddon mattseddon requested a review from shcheklein June 13, 2022 00:40
@mattseddon mattseddon requested a review from maxagin June 13, 2022 00:42
@shcheklein
Copy link
Member

Thanks @mattseddon ! let's not use Checkpoint Experiment though I don't think it's needed. (sign that it's still so complicated that we have to put some extra explanations - not good). Ideally you just Run an experiment, Continue running it,

I'm even thinking if Reset is needed at all (kinda it's should be a somewhat expected behavior?). But let's keep it for now.

@mattseddon mattseddon enabled auto-merge (squash) June 13, 2022 19:55
@codeclimate
Copy link

codeclimate bot commented Jun 13, 2022

Code Climate has analyzed commit 463a847 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.6% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit a9af582 into main Jun 13, 2022
@mattseddon mattseddon deleted the update-run-icons branch June 13, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR that affects product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants