Refactor experiments column conditional shadow logic #2085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* updating naming, making logic more clear * reduce complexity with `headerGroup` data
julieg18
commented
Jul 22, 2022
| @@ -102,6 +101,8 @@ export const TableHead = ({ | |||
|
|
|||
| const selectedForPlotsCount = getSelectedForPlotsCount(rows) | |||
|
|
|||
| const firstExpColumnCellId = headerGroups[0].headers[0].id | |||
There was a problem hiding this comment.
Instead of relying on array indexes to find the first experiments column cell, I realized I could find the cell with the id of the cell inside headerGroup.
| @@ -130,7 +130,7 @@ const getIconMenuItems = ( | |||
| } | |||
| ] | |||
|
|
|||
| const FirstTableHeaderCellWrapper: React.FC<{ | |||
| const WithExpColumnNeedsShadowUpdates: React.FC<{ | |||
There was a problem hiding this comment.
I tried to make the naming more clear but this sounds weird to me as well... Open to other suggestions 😅
julieg18
requested review from
mattseddon,
rogermparent,
sroy3 and
wolmir
as code owners
mattseddon
approved these changes
Jul 24, 2022
|
Code Climate has analyzed commit 97b855a and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.7% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
headerGroupdataFollowup to #2062 (comment)