-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redux for experiments table drag and drop #2097
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Code Climate has analyzed commit d6ee560 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 88.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.7% (0.0% change). View more on Code Climate. |
Sorry @sroy3 I'll test it now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great, thanks!
<Provider store={configureStore({ reducer: experimentsReducers })}> | ||
<div style={{ height: 400, width: 600 }}> | ||
<Experiments tableData={tableData} /> | ||
</div> | ||
</Provider> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe Provider
could be added with a decorator?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a good idea, I'll add this in my follow up PR
As this reducer already existed, it was easy to remove the
DragDropContext
and just use the reducer. Things seem to work just as they did for drag and drop. @wolmir can you test and tell me if I missed anything. All tests were passing, so it should be fine, but we never know...Starting work for #2103