Upgrade vsce #2108
Merged
Upgrade vsce #2108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
commented
Jul 27, 2022
|
|
||
| const yarnLock = resolve(__dirname, '..', 'yarn.lock') | ||
|
|
||
| ensureFileSync(yarnLock) |
There was a problem hiding this comment.
[F] Added this instead of using touch for mythical 🪟s contributors.
mattseddon
commented
Jul 27, 2022
| jest.config.js | ||
| tsconfig.json | ||
| webpack.config.ts | ||
| yarn.lock |
There was a problem hiding this comment.
After upgrading...
With old setup:
With this:
mattseddon
requested review from
rogermparent,
sroy3,
wolmir and
julieg18
as code owners
julieg18
approved these changes
Jul 27, 2022
sroy3
approved these changes
Jul 27, 2022
|
Code Climate has analyzed commit ea7ef64 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.7% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made some changes that enable us to move to the most recent version of VSCE (see #2101 for why we need to make changes).
I have tested the build locally. Would be good if someone else can also verify.
Please LMK if you would like to see anything done differently.
Thanks.