Add scheduled data status cli output test #2125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
force-pushed
the
cli-test-data-status
branch
from
465e568 to
4625502
Compare
mattseddon
force-pushed
the
cli-test-data-status
branch
from
4625502 to
a4fd1a2
Compare
mattseddon
commented
Aug 1, 2022
| @@ -91,8 +90,7 @@ export class RepositoryData extends DeferredDisposable { | |||
| const dataStatus = | |||
| await this.internalCommands.executeCommand<DataStatusOutput>( | |||
| AvailableCommands.DATA_STATUS, | |||
| this.dvcRoot, | |||
| Flag.UNCHANGED | |||
There was a problem hiding this comment.
[F] This was here because I was going to try and call for a full or partial update based on the path that fired the watcher. However, with the new data, it will require a more extensive rewrite to make this more efficient. Luckily the test caught the oversight.
mattseddon
commented
Aug 1, 2022
| 'status', | ||
| '--with-dirs', | ||
| '--granular', | ||
| '--unchanged', |
There was a problem hiding this comment.
mattseddon
requested review from
rogermparent,
sroy3,
wolmir and
julieg18
as code owners
sroy3
approved these changes
Aug 1, 2022
julieg18
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2/2
main<- #2091 <- thisAs promised here.
This PR adds a test to the daily CLI output test suite that runs against the
mainbranch of DVC.