Hide remove all buttons from trees when there is nothing to remove #2131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
mattseddon
force-pushed
the
hide-remove-all-buttons
branch
3 times, most recently
from
9857eef to
9c82aad
Compare
mattseddon
force-pushed
the
hide-remove-all-buttons
branch
from
9c82aad to
e21a2f5
Compare
mattseddon
requested review from
rogermparent,
sroy3,
wolmir and
julieg18
as code owners
sroy3
approved these changes
Aug 2, 2022
|
Code Climate has analyzed commit 6d01ccb and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.8% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1564
Demo
Screen.Recording.2022-08-02.at.11.35.15.am.mov
Note: Personally I think adding/removing icons to each
view/titlesection looks more like a bug. I think it was better to have icons consistently placed as they were previously.