Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS #2132

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Update CODEOWNERS #2132

merged 1 commit into from
Aug 2, 2022

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Aug 2, 2022

Rather than leaving @rogermparent in the CODEOWNERS file and having him ignore all PRs in this repo, I think it would be better to remove him and specifically request reviews when we need help.

WDYT?

@mattseddon mattseddon self-assigned this Aug 2, 2022
@mattseddon mattseddon changed the title Remove Roger from CODEOWNERS Update CODEOWNERS Aug 2, 2022
@mattseddon mattseddon marked this pull request as ready for review August 2, 2022 19:43
@rogermparent
Copy link
Contributor

I was thinking the same thing recently, I could be more helpful by only getting notifications when requested. If I want to see every PR, I can just look at the repo's PR page.

@codeclimate
Copy link

codeclimate bot commented Aug 2, 2022

Code Climate has analyzed commit 31942ad and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.8% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon enabled auto-merge (squash) August 2, 2022 19:52
@mattseddon mattseddon merged commit 3d6b236 into main Aug 2, 2022
@mattseddon mattseddon deleted the update-codeowners branch August 2, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants