Update cell hover styles #2198
Update cell hover styles #2198
Conversation
julieg18
force-pushed
the
update-cell-hover-style
branch
from
e564bb3 to
5dd030c
Compare
|
I don't like tbh, how text is moving a few pixels as you hover. Is it a bug or a feature? |
|
Color also doesn't change - is it expected? |
Whoops, wrong video! Text shouldn't be moving now.
Yes, we originally wanted to add a background color to the cells, but I'm having trouble finding a background color that works well across themes 🤔 Another option I considered was having the cell hover background be the table color, with or without borders:
|
julieg18
force-pushed
the
update-cell-hover-style
branch
from
5dd030c to
1cc0f1c
Compare
| @@ -166,12 +162,6 @@ $workspace-row-edge-margin: $edge-padding - $cell-padding; | |||
| border-bottom-color: $row-hover-background-color; | |||
| } | |||
|
|
|||
| .runningExperiment:not(.rowSelected) .experimentCell:hover & { | |||
There was a problem hiding this comment.
High contrast light theme
Dive bar:
There was a problem hiding this comment.
Figured out a way to fix the background, though the spinners border are still a slight different color. You can't really notice unless you squint, so should be good to merge :)
|
Code Climate has analyzed commit 9066afc and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.6% (0.0% change). View more on Code Climate. |
2/2
main<- #2197 <- thisExample of
maincell hover style:Example of PR cell hover style:
Screen.Recording.2022-08-16.at.3.26.12.PM.mov
Part of #2133 followup