Do not retry CLI process when unexpected error is received #2200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
force-pushed
the
do-not-retry-unexpected
branch
from
873b149 to
3f0d7ed
Compare
julieg18
approved these changes
Aug 17, 2022
sroy3
approved these changes
Aug 17, 2022
|
Code Climate has analyzed commit 8d8e8b2 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.7% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension of #2194 which is part of #2177.
Whilst talking with Ruslan in the DVC cross-team meeting we decided to exclude all unexpected errors from retries. Made more sense to make this the only change instead of branching off #2194.
For unexpected errors default data is now returned and the extension continues as normal. The user will then end up in this state until they make a commit:
Demo
Screen.Recording.2022-08-16.at.3.36.34.pm.mov
Note:
list,diffandstatusall return empty objects under these circumstances.