Make drop zones larger when dragging in the same section #2206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
reviewed
Aug 18, 2022
mattseddon
reviewed
Aug 18, 2022
| @@ -72,33 +72,44 @@ export const DragDropContainer: React.FC<DragDropContainerProps> = ({ | |||
| // eslint-disable-next-line sonarjs/cognitive-complexity | |||
| }) => { | |||
| const [draggedOverId, setDraggedOverId] = useState('') | |||
| const [hoveringSomething, setHoveringSomething] = useState(false) | |||
There was a problem hiding this comment.
[Q] what is the difference between hoveringSomething and isHovering, why do we need both?
There was a problem hiding this comment.
They are working together. And it's because of:
const handleDragLeave = () => {
isHovering.current = false
hoveringTimeout.current = window.setTimeout(() => {
if (!isHovering.current) {
setHoveringSomething(false)
}
}, 500)
}
onDragLeave is a little too reactive and changing the state every time is a lot. Not only that but there is also a race condition with onDragEnter of other elements.
mattseddon
approved these changes
Aug 18, 2022
|
Code Climate has analyzed commit 98b5d8b and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 89.5% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.6% (-0.1% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2115
Screen.Recording.2022-08-17.at.3.34.28.PM.mov
Screen.Recording.2022-08-17.at.3.54.44.PM.mov