Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sticky workspace row obscuring branch #2212

Merged
merged 2 commits into from
Aug 18, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix sticky workspace row obscuring branch
mattseddon committed Aug 18, 2022
commit 8719d1a49d360a67046e46d1655802a40ec22e36
2 changes: 1 addition & 1 deletion webview/src/experiments/components/table/TableHead.tsx
Original file line number Diff line number Diff line change
@@ -49,7 +49,7 @@ export const TableHead = ({
if (wrapperHeight) {
setTableHeadHeight(wrapperHeight)
}
}, [setTableHeadHeight])
}, [setTableHeadHeight, headerGroups])
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alternative is to use allHeaders here and wrap its creation in useMemo but I think this is fine.


const onDragStart: DragFunction = ({ currentTarget }) => {
const displacerHeader = allHeaders.find(