Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a copy button for comparison table rows #2216

Merged
merged 11 commits into from
Aug 19, 2022
Merged

Conversation

sroy3
Copy link
Contributor

@sroy3 sroy3 commented Aug 18, 2022

Screen.Recording.2022-08-18.at.1.48.10.PM.mov

@sroy3 sroy3 added the product PR that affects product label Aug 18, 2022
@sroy3 sroy3 self-assigned this Aug 18, 2022
@sroy3 sroy3 marked this pull request as ready for review August 18, 2022 17:48
@shcheklein
Copy link
Member

Thanks @sroy3 for taking care of this ... can we also make names "selectable" as a regular text?

@sroy3
Copy link
Contributor Author

sroy3 commented Aug 18, 2022

Thanks @sroy3 for taking care of this ... can we also make names "selectable" as a regular text?

Just added. Might be a little annoying because it's a button that toggles the row, but it isn't a destructive action.

Screen.Recording.2022-08-18.at.1.52.00.PM.mov

@shcheklein
Copy link
Member

Thanks! QQ - is there a way to recognize that it was in the "selection mode" and do not activate the action?

@sroy3
Copy link
Contributor Author

sroy3 commented Aug 18, 2022

Thanks! QQ - is there a way to recognize that it was in the "selection mode" and do not activate the action?

Wasn't easy, but I got it!

Screen.Recording.2022-08-18.at.2.37.30.PM.mov

@sroy3 sroy3 enabled auto-merge (squash) August 19, 2022 12:47
@codeclimate
Copy link

codeclimate bot commented Aug 19, 2022

Code Climate has analyzed commit ade5bf2 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.6% (0.0% change).

View more on Code Climate.

@sroy3 sroy3 merged commit 7b6d699 into main Aug 19, 2022
@sroy3 sroy3 deleted the comparison-copy-button branch August 19, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR that affects product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants