Share an experiment from command palette #2221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| ) | ||
| ) | ||
|
|
||
| internalCommands.registerExternalCliCommand( |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
mattseddon
force-pushed
the
share-experiment-command
branch
from
3ace691 to
62ef625
Compare
sroy3
approved these changes
Aug 19, 2022
julieg18
approved these changes
Aug 19, 2022
mattseddon
force-pushed
the
share-experiment-command
branch
from
62ef625 to
b105672
Compare
|
Code Climate has analyzed commit b105672 and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.6% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2/2
main<- #2219 <- thisThis PR builds on #2219 by adding a command to the palette which can be used to share an experiment.
Demo
Screen.Recording.mov