Make some timestamp processing suggestions #2247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mattseddon
commented
Aug 24, 2022
mattseddon
commented
- Make timestamp column hideable
- make some suggestions
mattseddon
changed the base branch from
main
to
make-timestamp-column-hideable
mattseddon
commented
Aug 24, 2022
| @@ -228,8 +228,7 @@ const TableHeaderCell: React.FC<{ | |||
| setExpColumnNeedsShadow | |||
| }) => { | |||
| const [menuSuppressed, setMenuSuppressed] = React.useState<boolean>(false) | |||
| const isDraggable = | |||
| !column.placeholderOf && !['id', 'timestamp'].includes(column.id) | |||
| const isDraggable = !column.placeholderOf && !['id'].includes(column.id) | |||
There was a problem hiding this comment.
[F] And now can magically drag and drop the column....
mattseddon
commented
Aug 24, 2022
| @@ -4,8 +4,8 @@ import { ColumnType } from '../../webview/contract' | |||
| export const timestampColumn = { | |||
| hasChildren: false, | |||
| label: 'Timestamp', | |||
| parentPath: 'timestamp', | |||
| path: 'timestamp:timestamp', | |||
| parentPath: ColumnType.TIMESTAMP, | |||
There was a problem hiding this comment.
I would see if it is possible to change this to an optional property and drop it from here.
|
Code Climate has analyzed commit 995eb87 and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.7% (0.0% change). View more on Code Climate. |
julieg18
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.