Give option to sort or filter by Created timestamp #2293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
commented
Aug 30, 2022
| label: columnLike.label, | ||
| value: columnLike | ||
| })), | ||
| columnLikes.map(columnLike => ({ |
There was a problem hiding this comment.
[F] Sorting takes care of itself because the timestamp is an ISO string.
mattseddon
commented
Aug 30, 2022
julieg18
reviewed
Aug 30, 2022
sroy3
approved these changes
Aug 30, 2022
|
Thanks, @julieg18 I'll fix everything. |
julieg18
approved these changes
Aug 31, 2022
|
Code Climate has analyzed commit 362cf8f and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 83.6% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.7% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gives users the ability to sort/filter by the created column. Follow up from #2239 (comment).
Demo
https://user-images.githubusercontent.com/37993418/187358368-d7bdd74d-123d-42ec-8f0b-60a49f4d0754.movScreen.Recording.2022-08-31.at.10.15.29.am.mov