Update selected row foreground #2391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julieg18
commented
Sep 13, 2022
| @@ -15,6 +15,7 @@ $row-bg-color: $bg-color; | |||
| $header-fg-color: $fg-color; | |||
| $row-bg-alt-color: var(--vscode-sideBar-background); | |||
| $row-bg-selected-color: var(--vscode-list-activeSelectionBackground); | |||
| $row-fg-selected-color: var(--vscode-list-activeSelectionForeground); | |||
There was a problem hiding this comment.
From what I can tell, this variable is always set in all themes so we don't need to a fallback like we did with the icon color.
sroy3
approved these changes
Sep 13, 2022
mattseddon
approved these changes
Sep 13, 2022
|
Code Climate has analyzed commit 290ba66 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 97.0% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo
Screen.Recording.2022-09-13.at.10.28.08.AM.mov
Followup to #2367 comment