Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hints into experiment table row action tooltips #2567

Merged
merged 1 commit into from
Oct 15, 2022
Merged

Conversation

mattseddon
Copy link
Contributor

@mattseddon mattseddon commented Oct 12, 2022

2/2 main <- #2553 <- this

This PR adds hints to the experiment table row action tooltips. Initially, I wanted to highlight how to open the plots' view but seems like a good idea to try and put something useful into the starred tooltip as well.

Demo

Screen.Recording.2022-10-12.at.1.01.01.pm.mov

@mattseddon mattseddon added the product PR that affects product label Oct 12, 2022
@mattseddon mattseddon self-assigned this Oct 12, 2022
@mattseddon mattseddon changed the base branch from main to add-eye October 12, 2022 02:05
@mattseddon mattseddon marked this pull request as ready for review October 12, 2022 02:11
Copy link
Contributor

@julieg18 julieg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@shcheklein
Copy link
Member

shcheklein commented Oct 13, 2022

Can we put an action on the tooltip (make it clickable)?

Unplot --> "hide plots" ?

Can we do the same tooltip in the side panel?

Overall, looks good to me. If we can make it actionable, we can simplify it to "Open the plots view".

@mattseddon
Copy link
Contributor Author

@shcheklein

Can we do the same tooltip in the side panel?

Would you prioritize this over adding extra data into the tooltip as per #2395 (comment)

I can try to combine the two but I don't think it will look very good/be as useful there.

@shcheklein
Copy link
Member

shcheklein commented Oct 14, 2022

I was thinking about the circle tooltip only.

There is only one tooltip per row.

We can see how the combination would look like (not the full text, it should be like we "Click to toggle plot visibility ... link"

I'll take that as a task for when I get back to #2395

Base automatically changed from add-eye to main October 15, 2022 01:29
@codeclimate
Copy link

codeclimate bot commented Oct 15, 2022

Code Climate has analyzed commit 3b5acdf and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.8%.

View more on Code Climate.

@mattseddon
Copy link
Contributor Author

Will follow up to make tooltip actionable

@mattseddon mattseddon merged commit 510f34d into main Oct 15, 2022
@mattseddon mattseddon deleted the improve-tooltip branch October 15, 2022 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR that affects product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants