-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hints into experiment table row action tooltips #2567
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
Can we put an action on the tooltip (make it clickable)? Unplot --> "hide plots" ? Can we do the same tooltip in the side panel? Overall, looks good to me. If we can make it actionable, we can simplify it to "Open the plots view". |
Would you prioritize this over adding extra data into the tooltip as per #2395 (comment) I can try to combine the two but I don't think it will look very good/be as useful there. |
There is only one tooltip per row.
I'll take that as a task for when I get back to #2395 |
246b36f
to
a5be077
Compare
a5be077
to
3b5acdf
Compare
Code Climate has analyzed commit 3b5acdf and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.8%. View more on Code Climate. |
Will follow up to make tooltip actionable |
2/2
main
<- #2553 <- thisThis PR adds hints to the experiment table row action tooltips. Initially, I wanted to highlight how to open the plots' view but seems like a good idea to try and put something useful into the starred tooltip as well.
Demo
Screen.Recording.2022-10-12.at.1.01.01.pm.mov