Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the DVC: Get Started / Plots Dashboard #2573

Merged
merged 12 commits into from
Nov 4, 2022
Merged

Conversation

maxagin
Copy link
Contributor

@maxagin maxagin commented Oct 12, 2022

Select (click the circle beside the experiment name) one or more up to 7 experiments in the table view to visualize in the Plots Dashboard. screenshot
Use DVC: Show Plots from the command palette to open it or open it using the table's row context menu.

Screen.Recording.2022-11-02.at.10.23.04.PM.mov

@shcheklein : We need to wait for the #2553 to land

Select (click the circle beside the experiment name) one or more up to 7 experiments in the table view to visualize in the Plots Dashboard.
screenshot
Use DVC: Show Plots from the command palette to open it or open it using the table's row context menu.
@shcheklein
Copy link
Member

Thanks @maxagin . The image should be also part of this PR please.

Also, please see in the file and wrap text at 80 symbols.

@maxagin
Copy link
Contributor Author

maxagin commented Oct 13, 2022

The screenshot was updated. Thanks

@maxagin
Copy link
Contributor Author

maxagin commented Oct 13, 2022

Sorry forgot to wrap the text. Will create an update

@@ -1,9 +1,17 @@
# Plots Dashboard

Select one or more experiments to visualize in the
[**Plots Dashboard**](command:dvc.showPlots). Use
Select (click the circle beside the 🧪 experiment name) up to 7 experiments in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's please remove the emoji (we don't use them in the walkthrough this way).

Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shcheklein shcheklein added the blocked Issue or pull request blocked due to other dependencies or issues label Oct 14, 2022
@mattseddon mattseddon added product PR that affects product and removed blocked Issue or pull request blocked due to other dependencies or issues labels Oct 17, 2022
@shcheklein
Copy link
Member

The problem with this approach is that people don't see now the plots dashboard itself when they open the page (they would need to scroll). Should we change the order of things?

@maxagin
Copy link
Contributor Author

maxagin commented Oct 20, 2022

The problem with this approach is that people don't see now the plots dashboard itself when they open the page (they would need to scroll). Should we change the order of things?

Maybe we can rename the section titles e.g.

  • Experiments View Experiments Table
  • Plots View Plots Dashboard

Screen Shot 2022-10-20 at 6 21 50 PM

WDYT?

Otherwise, we need to change the textual content I think.


that people don't see now the plots dashboard

Before it also was not at the top!

Screen Shot 2022-10-20 at 6 27 10 PM

@shcheklein
Copy link
Member

@maxagin re renaming - let's do one thing at at a time please ;)

Was it at least somewhat visible? My point is that even if it was bad we are making it worse. Should we reorder things a bit?

@maxagin
Copy link
Contributor Author

maxagin commented Oct 21, 2022

A possible solution is to add overview images for some sections e.g. sidebar, EXPs, Plots. I like this solution also because we educate users on what views we actually have and how possibly you should organize the panels WDYT @shcheklein ?

Screen Shot 2022-10-20 at 9 45 19 PM

Screen Shot 2022-10-20 at 9 45 28 PM

Screen Shot 2022-10-20 at 9 45 38 PM

@shcheklein
Copy link
Member

shcheklein commented Oct 21, 2022

@maxagin feels a bit too much and more images to maintain.

@shcheklein
Copy link
Member

@maxagin so, how about changing the order and finally merging this and the second PR (we can release everything today / tomorrow then)?

@maxagin
Copy link
Contributor Author

maxagin commented Oct 26, 2022

more images to maintain.

  1. Three more images won't make any difference if all the images will have to be changed.
  2. Personally I think this is a very clever idea - to show right away the main extension views, thus we can educate the user about what he can expect and hopefully reduce the number of leaving users.

changing the order

I am not sure this is good, as the content of this section is clearly organized to explain what you need to do step by step:

  1. What to do to show EXPs in Plots view
  2. Types of plots
  3. Explaining the types

@shcheklein, what is your take on this?

@shcheklein
Copy link
Member

@maxagin any updates on this? :)

@maxagin
Copy link
Contributor Author

maxagin commented Nov 2, 2022

Completely went out of my radar! I will deal with it ASAP @shcheklein

@maxagin maxagin self-assigned this Nov 2, 2022
@maxagin maxagin requested a review from shcheklein November 3, 2022 02:29
@shcheklein
Copy link
Member

@maxagin could you update / or upload the video please?

@maxagin
Copy link
Contributor Author

maxagin commented Nov 3, 2022

@shcheklein the description video is updated.

@codeclimate
Copy link

codeclimate bot commented Nov 3, 2022

Code Climate has analyzed commit 2b2cc5c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.8% (0.0% change).

View more on Code Climate.

@maxagin maxagin merged commit 6faccb8 into main Nov 4, 2022
@maxagin maxagin deleted the maxagin-patch-1-1 branch November 4, 2022 01:35
@julieg18 julieg18 mentioned this pull request Nov 17, 2022
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR that affects product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants