-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use error foreground for status bar item color if CLI unavailable #2587
Conversation
Cool, thanks Matt. Can we do the same on the side panel (where we put a message that DVC is incompatible). Also may be give a hint there about the current version of DVC, put a link to docs (get started walkthough)? |
I will check the API but I don't think so.
There is already a toast popup with this information. |
Yes, but it's easy to dismiss it and then you are lost. Another, out of scope, but a bit related suggestion to improve the awareness is to change the quick pick to always show three options (gray out the Python one if extension is not installed, show the message that it needs to be installed if you want to pick the env automatically) |
Fair point but the text in the sidebar has to be static we cannot inject values into it.
The API does not allow us to do this either. |
Code Climate has analyzed commit c7c4d46 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.8% (0.0% change). View more on Code Climate. |
Thanks, Matt! It's a good improvement. We still need to think on what to do on the side panel / webviews to make it 100% clear what's going on and how to solve the issue. |
From https://iterativeai.slack.com/archives/C01APS0FHDM/p1665690104423039?thread_ts=1665680827.468069&cid=C01APS0FHDM
"Extension is not initialized (should we be highlighting this better ( in red op yellow with a warning symbol?)"
Demo
Screen.Recording.2022-10-14.at.7.35.12.am.mov