Follow directions in the VS Code API docs for relative paths

[mattseddon]

Possible cause of #2562 and some of the stability issues that we've been seeing.

From the API:

    /**
     * A relative pattern is a helper to construct glob patterns that are matched
     * relatively to a base file path. The base path can either be an absolute file
     * path as string or uri or a {@link WorkspaceFolder workspace folder}, which is the
     * preferred way of creating the relative pattern.
     */
    export class RelativePattern {
...
         * @param base A base to which this pattern will be matched against relatively. It is recommended
         * to pass in a {@link WorkspaceFolder workspace folder} if the pattern should match inside the workspace.
         * Otherwise, a uri or string should only be used if the pattern is for a file path outside the workspace.
         * @param pattern A file glob pattern like `*.{ts,js}` that will be matched on paths relative to the base.
         */
        constructor(base: WorkspaceFolder | Uri | string, pattern: string);

The important line: Otherwise, a uri or string should only be used if the pattern is for a file path outside the workspace.

[julieg18]

Looks good!

[codeclimate]

Code Climate has analyzed commit 52a5268 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.8% (0.0% change).

View more on Code Climate.