Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experiment details when selecting exps for plots #2670

Merged
merged 3 commits into from
Oct 25, 2022

Conversation

julieg18
Copy link
Contributor

@julieg18 julieg18 commented Oct 24, 2022

  • fills pickExperiment quick pick item details with values of first three columns in table

Demo

Screen.Recording.2022-10-24.at.6.50.45.PM.mov

Part of #2395

* fill quick pick items with values of first three columns
@julieg18 julieg18 added the product PR that affects product label Oct 24, 2022
@julieg18 julieg18 self-assigned this Oct 24, 2022
@julieg18 julieg18 marked this pull request as ready for review October 25, 2022 00:03
Copy link
Contributor

@sroy3 sroy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@codeclimate
Copy link

codeclimate bot commented Oct 25, 2022

Code Climate has analyzed commit 8e35444 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 96.3% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.8% (0.0% change).

View more on Code Climate.

@julieg18 julieg18 merged commit ba3d6d0 into main Oct 25, 2022
@julieg18 julieg18 deleted the add-metrics-to-experiments-quick-pick branch October 25, 2022 21:52
@mattseddon
Copy link
Contributor

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR that affects product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants