-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delay creation of plots to remove optional logic #2832
Conversation
this.dvcRoots, | ||
this.updatesPaused, | ||
this.resourceLocator, | ||
this.experiments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[F] By creating this after we have created the experiments repositories we can simply/remove a lot of the optional chaining logic from Plots
and PlotsData
(model is passed in on instantiation instead of being set afterwards).
d3a043c
to
c6455f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On my end, loading plots can take a little while (mainly because that's usually the first thing I open when launching the extension). Wondering if the message should say more than just "Loading Plots..." If we are delaying their creation + already long loading time.
Technically this change shouldn't hurt performance as we have to wait for experiments to be built before we know which revisions to request. This is just a simpler/smarter way to structure the code. |
Code Climate has analyzed commit 142152d and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 92.5% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.6% (0.0% change). View more on Code Climate. |
This is a precursor to the work being done in #2831. We can simplify some of the logic in
Plots
andPlotsData
by delaying the creation of plots repositories until afterExperiments
have been created for each dvc root.