Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update multi source test fixture to contain the expected revisions (branch revision not name) #2837

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Nov 26, 2022

2/2 main <- #2836 <- this

This PR correctly fixes the issue with the flexible plots test fixture discovered in #2836 (and undoes the patch).

plots diff is currently called with the branch revision and not the name.

@mattseddon mattseddon self-assigned this Nov 26, 2022
@mattseddon mattseddon changed the base branch from main to fix-available-revisions November 26, 2022 23:41
@mattseddon mattseddon marked this pull request as ready for review November 26, 2022 23:42
@mattseddon mattseddon force-pushed the fix-multi-source-plots-data branch from c8a75a0 to 7d201df Compare November 26, 2022 23:43
Base automatically changed from fix-available-revisions to main November 26, 2022 23:53
@mattseddon mattseddon force-pushed the fix-multi-source-plots-data branch from 7d201df to b2afc67 Compare November 26, 2022 23:54
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 25725 lines exceeds the maximum allowed for the inline comments feature.

@codeclimate
Copy link

codeclimate bot commented Nov 27, 2022

Code Climate has analyzed commit b2afc67 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.6%.

View more on Code Climate.

Copy link
Contributor

@sroy3 sroy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Wouldn't have figured it on my own quickly.

@sroy3 sroy3 merged commit a721c0a into main Nov 28, 2022
@sroy3 sroy3 deleted the fix-multi-source-plots-data branch November 28, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants