-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve plots ribbon block tooltips #2956
Conversation
* highlight table keys based off type * add copy button to table values
Amazing improvement! QQ - when it a number, does the copy button copy an actual value? Just to double check? And same with data hash ... |
When you say the "actual value", are you referring to the value that isn't truncated? If so, yes! |
path: path.slice(type.length + 1) || path, | ||
type, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Q] Why not send only the raw data from the model and have the client(s) format it? See webview/src/experiments/util/buildDynamicColumns.tsx
for how this is handled by the experiments table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If not there is some commonality with ExperimentsTree.getTooltipTable
. The duplication should be removed/combined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It definitely would simplify the code a lot! Will do it in a followup :)
Code Climate has analyzed commit bdbe132 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.6% (0.0% change). View more on Code Climate. |
Demo
demo.mov
Followup to #2924, Fixes #2457