Direct users to setup webview from warning popups #2990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
commented
Dec 22, 2022
| @@ -1355,7 +1355,7 @@ | |||
| }, | |||
| { | |||
| "view": "dvc.views.webviews", | |||
| "contents": "[Show Experiments](command:dvc.showSetupWebview)\n[Show Plots](command:dvc.showSetupdWebview)\n[Show Experiments and Plots](command:dvc.showSetupWebview)", | |||
There was a problem hiding this comment.
there was a stray d in showSetupdWebview
mattseddon
force-pushed
the
direct-to-setup-webview
branch
from
a414284 to
474e972
Compare
|
Code Climate has analyzed commit 474e972 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 90.4% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.4% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2/2
main<- #2944 <- thisThis is the first step in integrating the Setup webview with existing user flows. We are now:
Demo
Screen.Recording.2022-12-22.at.1.04.56.pm.mov
(no stray toast)
Screen.Recording.2022-12-22.at.1.05.36.pm.mov