Add ability to stop experiments running in the queue into stop experiments command #3157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
force-pushed
the
add-stop-queue-to-button
branch
from
4b738ae to
b457530
Compare
|
Q: does it stop (kill) all the experiments. E.g. If I have one running in the queue and one in the workspace- will it kill both of them now? |
Yes, it will. I thought this was the best way to unify the functionality. |
sroy3
approved these changes
Jan 25, 2023
mattseddon
force-pushed
the
update-queue-terminology
branch
from
0743146 to
3e72451
Compare
mattseddon
force-pushed
the
add-stop-queue-to-button
branch
from
b457530 to
b8d7aeb
Compare
|
Code Climate has analyzed commit b8d7aeb and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 90.9% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.0% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2/3
main<- #3154 <- this <- #3158Related to #3091.
Demo
Screen.Recording.2023-01-25.at.4.10.57.pm.mov