Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine remove experiments and remove queued experiment quick picks #3166

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

mattseddon
Copy link
Contributor

@mattseddon mattseddon commented Jan 27, 2023

1/2 main <- this <- #3167

Related to #3091

This PR drops the dvc.removeQueuedExperiment quick pick command and enables users to select queued experiments through dvc.removeExperiments. In other words, we are combining the commands. For now I have left the DVC: Remove All Queued Experiments (dvc exp remove --queue) command in the UI as I think it has it's own place but we can remove that as well if we want to.

Demo

Screen.Recording.2023-01-27.at.1.57.08.pm.mov

@mattseddon mattseddon added the product PR that affects product label Jan 27, 2023
@mattseddon mattseddon self-assigned this Jan 27, 2023
@mattseddon mattseddon force-pushed the combine-remove-experiments branch from a5d638a to ca07d07 Compare January 27, 2023 03:38
@mattseddon mattseddon marked this pull request as ready for review January 27, 2023 03:50
@mattseddon mattseddon requested a review from shcheklein January 27, 2023 03:50
Copy link
Contributor

@julieg18 julieg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mattseddon mattseddon force-pushed the combine-remove-experiments branch from ca07d07 to c496306 Compare January 27, 2023 21:24
@mattseddon mattseddon enabled auto-merge (squash) January 27, 2023 21:24
@codeclimate
Copy link

codeclimate bot commented Jan 27, 2023

Code Climate has analyzed commit c496306 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.9% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit 46898a0 into main Jan 27, 2023
@mattseddon mattseddon deleted the combine-remove-experiments branch January 27, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR that affects product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants