-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update dependency @vscode/extension-telemetry to v0.7.5 #3274
Conversation
43fba1f
to
f663e34
Compare
needs work to be able to merge |
85a9ea6
to
d97703f
Compare
eb1d998
to
adac6e8
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. ⚠ Warning: custom changes will be lost. |
@sroy3 @julieg18 can you please review the changes that I've made. I have tested locally and everything seems to work as expected. These are my events with the built VSIX: Screen.Recording.2023-02-14.at.9.49.58.am.movFrom looking at that it appears that |
There are no more |
🙏🏻. This now makes sense to me: |
@@ -26,16 +26,6 @@ export const getExtensionAPI = async <T>( | |||
} catch {} | |||
} | |||
|
|||
export const getExtensionVersion = <T>(id: string): string | undefined => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an information that could be useful? Maybe this could be added in the sendTelemetryEvent
function just like the user_id.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it gets automatically sent by the Telemetry now, it picks up the information itself
adac6e8
to
4018994
Compare
Code Climate has analyzed commit 4018994 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.9% (0.0% change). View more on Code Climate. |
This PR contains the following updates:
0.6.2
->0.7.5
Release Notes
Microsoft/vscode-extension-telemetry
v0.7.5
: Utilize the new telemetry APICompare Source
Note: This breaks the
.d.ts
file in that it removes some extension specific information from the constructor in favor of just supplying the key.This module will now directly consume the VS Code telemetry API announced with the release of 1.75.0. This API should vastly improve the telemetry experience.
New Features
sendTelemetryException
function.Extension Telemetry
output channel that allows you to see and debug the flow of telemetry in product when log level is set to traceError
telemetry level rather than a simple on off switch.Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.