Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency @vscode/extension-telemetry to v0.7.5 #3274

Merged
merged 2 commits into from
Feb 14, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 13, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@vscode/extension-telemetry 0.6.2 -> 0.7.5 age adoption passing confidence

Release Notes

Microsoft/vscode-extension-telemetry

v0.7.5: Utilize the new telemetry API

Compare Source

Note: This breaks the .d.ts file in that it removes some extension specific information from the constructor in favor of just supplying the key.

This module will now directly consume the VS Code telemetry API announced with the release of 1.75.0. This API should vastly improve the telemetry experience.

New Features

  • Automatic error handling logged to your sendTelemetryException function.
  • A shared Extension Telemetry output channel that allows you to see and debug the flow of telemetry in product when log level is set to trace
  • PII cleaning which is automatically updated with the version of VS Code
  • Support for the new Error telemetry level rather than a simple on off switch.

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot force-pushed the renovate/vscode-extension-telemetry-0.x branch from 43fba1f to f663e34 Compare February 13, 2023 19:59
@mattseddon
Copy link
Member

needs work to be able to merge

@renovate renovate bot force-pushed the renovate/vscode-extension-telemetry-0.x branch 2 times, most recently from 85a9ea6 to d97703f Compare February 13, 2023 22:40
@mattseddon mattseddon force-pushed the renovate/vscode-extension-telemetry-0.x branch 2 times, most recently from eb1d998 to adac6e8 Compare February 13, 2023 22:45
@renovate
Copy link
Contributor Author

renovate bot commented Feb 13, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@mattseddon
Copy link
Member

@sroy3 @julieg18 can you please review the changes that I've made. I have tested locally and everything seems to work as expected.

These are my events with the built VSIX:

Screen.Recording.2023-02-14.at.9.49.58.am.mov

From looking at that it appears that views.experimentsTable.columnResized is still firing way too often. Is this working as expected?:

https://github.com/iterative/vscode-dvc/blob/main/webview/src/experiments/components/Experiments.tsx#L106

@mattseddon mattseddon removed their request for review February 13, 2023 22:55
@sroy3
Copy link
Contributor

sroy3 commented Feb 13, 2023

From looking at that it appears that views.experimentsTable.columnResized is still firing way too often. Is this working as expected?:

https://github.com/iterative/vscode-dvc/blob/main/webview/src/experiments/components/Experiments.tsx#L106

There are no more onResizeDone event with React Table (I'll recheck to make sure). I added a debounce, but if you're seeing it that often, it doesn't look like it's working properly. I'll look into tomorrow.

@mattseddon
Copy link
Member

From looking at that it appears that views.experimentsTable.columnResized is still firing way too often. Is this working as expected?:
https://github.com/iterative/vscode-dvc/blob/main/webview/src/experiments/components/Experiments.tsx#L106

There are no more onResizeDone event with React Table (I'll recheck to make sure). I added a debounce, but if you're seeing it that often, it doesn't look like it's working properly. I'll look into tomorrow.

🙏🏻. This now makes sense to me:

image

@@ -26,16 +26,6 @@ export const getExtensionAPI = async <T>(
} catch {}
}

export const getExtensionVersion = <T>(id: string): string | undefined => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an information that could be useful? Maybe this could be added in the sendTelemetryEvent function just like the user_id.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it gets automatically sent by the Telemetry now, it picks up the information itself

@mattseddon mattseddon force-pushed the renovate/vscode-extension-telemetry-0.x branch from adac6e8 to 4018994 Compare February 14, 2023 21:01
@mattseddon mattseddon enabled auto-merge (squash) February 14, 2023 21:01
@codeclimate
Copy link

codeclimate bot commented Feb 14, 2023

Code Climate has analyzed commit 4018994 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.9% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit b7bcaf9 into main Feb 14, 2023
@mattseddon mattseddon deleted the renovate/vscode-extension-telemetry-0.x branch February 14, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants