Improve naming in experiment row context menu component #3346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
commented
Feb 24, 2023
| @@ -175,7 +175,7 @@ const getSingleSelectMenuOptions = ( | |||
|
|
|||
| const notExperiment = depth !== 1 | |||
|
|
|||
| const withId = ( | |||
| const notRunningWithId = ( | |||
There was a problem hiding this comment.
I have now been caught out by this POS a few times. It silently added || hasRunningExperiment to the hidden options which leads to plenty of head scratching. Name is updated to reflect what it is actually doing.
mattseddon
commented
Feb 24, 2023
| 'Share to Studio', | ||
| MessageFromWebviewType.SHARE_EXPERIMENT_TO_STUDIO, | ||
| notExperiment || hasRunningExperiment, | ||
| notExperiment, |
There was a problem hiding this comment.
[F] Should be no behaviour change here.
sroy3
approved these changes
Feb 24, 2023
mattseddon
force-pushed
the
not-running
branch
from
5b2de94 to
ae65ab8
Compare
mattseddon
force-pushed
the
not-running
branch
from
ae65ab8 to
461bf31
Compare
|
Code Climate has analyzed commit 461bf31 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.0%. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments inline