Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prototype stub (flaky test) #3355

Merged
merged 2 commits into from
Feb 27, 2023
Merged

Update prototype stub (flaky test) #3355

merged 2 commits into from
Feb 27, 2023

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Feb 26, 2023

Another attempt to fix up the flakiest part of the CI.

const mockGetDvcRoots = stub(Setup.prototype, 'getRoots').returns([
dvcDemoPath
])

const mockCanRunCli = stub(DvcReader.prototype, 'version')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[F] I'm thinking that runWithRecheck is using up these calls.

@mattseddon mattseddon force-pushed the update-prototype-stub branch from 86eeb94 to 6f043cd Compare February 26, 2023 21:57
@mattseddon mattseddon marked this pull request as ready for review February 27, 2023 21:15
@mattseddon mattseddon enabled auto-merge (squash) February 27, 2023 21:16
@codeclimate
Copy link

codeclimate bot commented Feb 27, 2023

Code Climate has analyzed commit bad5c8f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.0% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit 8920d4c into main Feb 27, 2023
@mattseddon mattseddon deleted the update-prototype-stub branch February 27, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants