Add DvcViewer class #3359
Merged
Add DvcViewer class #3359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
force-pushed
the
add-viewer
branch
2 times, most recently
from
cbdc134 to
dd32776
Compare
This was referenced Feb 27, 2023
This was referenced Feb 27, 2023
sroy3
approved these changes
Feb 27, 2023
mattseddon
force-pushed
the
add-viewable-process
branch
from
cc067d6 to
86d6d7c
Compare
mattseddon
force-pushed
the
add-viewer
branch
from
dd32776 to
616c35e
Compare
|
Code Climate has analyzed commit 616c35e and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 90.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.0% (0.0% change). View more on Code Climate. |
|
Related to #3178 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3/5
main<- #3356 <- #3358 <- this <- #3361 <- #3362This PR adds a DvcViewer class used to manage multiple
ViewableCliProcesses. The class will be used to create processes that can/do show a Pseudoterminal containing the process' output. This class will initially be used to show logs for experiments running the queue.