Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing loading screen to Custom section #3524

Merged
merged 2 commits into from
Mar 21, 2023
Merged

Add missing loading screen to Custom section #3524

merged 2 commits into from
Mar 21, 2023

Conversation

julieg18
Copy link
Contributor

@julieg18 julieg18 commented Mar 21, 2023 •
edited
Loading

  • wasn't sure how I could demo it since it happens too fast for me to see a loading screen 🤔

Part of #3373

@julieg18 julieg18 added the bug Something isn't working label Mar 21, 2023
@julieg18 julieg18 self-assigned this Mar 21, 2023
@julieg18 julieg18 marked this pull request as ready for review March 21, 2023 15:48
@codeclimate
Copy link

codeclimate bot commented Mar 21, 2023

Code Climate has analyzed commit 48bab6b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.0% (0.0% change).

View more on Code Climate.

@julieg18 julieg18 merged commit 0eec736 into main Mar 21, 2023
@julieg18 julieg18 deleted the add-loading-screen-to-custom branch March 21, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sroy3 sroy3 sroy3 approved these changes

@mattseddon mattseddon Awaiting requested review from mattseddon mattseddon is a code owner

Assignees

@julieg18 julieg18

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julieg18 @sroy3