Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code that refreshes a single plot revision (no longer possible) #3555

Merged
merged 1 commit into from
Apr 2, 2023

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Mar 26, 2023

Note: starting a new chain as this is number 10 away from main. Does not seem like a good use of time to maintain the already approved PR descriptions.

1/2 main <- this <- #3557

This PR removes the code relating to refreshing a single revision. It is no longer possible to refresh a single revision after #3532.

@mattseddon mattseddon self-assigned this Mar 26, 2023
@mattseddon mattseddon changed the base branch from main to consolidate-decoration-provider March 26, 2023 22:12
@mattseddon mattseddon changed the base branch from consolidate-decoration-provider to main March 26, 2023 22:19
@mattseddon mattseddon force-pushed the remove-single-revision-refresh branch from e50f899 to a3bdefb Compare March 26, 2023 22:29
@mattseddon mattseddon changed the base branch from main to consolidate-decoration-provider March 26, 2023 22:37
@mattseddon mattseddon force-pushed the remove-single-revision-refresh branch from a3bdefb to 4f37e57 Compare March 26, 2023 23:46
@mattseddon mattseddon marked this pull request as ready for review March 26, 2023 23:46
Copy link
Contributor

@julieg18 julieg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mattseddon mattseddon force-pushed the consolidate-decoration-provider branch from 5568e8f to 011dc8a Compare April 2, 2023 06:15
Base automatically changed from consolidate-decoration-provider to main April 2, 2023 06:29
@mattseddon mattseddon force-pushed the remove-single-revision-refresh branch from 4f37e57 to 55170d2 Compare April 2, 2023 06:30
@mattseddon mattseddon enabled auto-merge (squash) April 2, 2023 06:32
@codeclimate
Copy link

codeclimate bot commented Apr 2, 2023

Code Climate has analyzed commit 55170d2 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.1%.

View more on Code Climate.

@mattseddon mattseddon merged commit c0443af into main Apr 2, 2023
@mattseddon mattseddon deleted the remove-single-revision-refresh branch April 2, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants