Display error thrown by Plots Diff in Plots tree #3569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
changed the base branch from
fix-error-collection
to
switch-fetch-to-false
mattseddon
force-pushed
the
handle-global-error
branch
3 times, most recently
from
c873fe5 to
92a6f56
Compare
sroy3
approved these changes
Mar 28, 2023
mattseddon
force-pushed
the
switch-fetch-to-false
branch
from
a167130 to
1ac8932
Compare
mattseddon
force-pushed
the
handle-global-error
branch
from
92a6f56 to
e4643ba
Compare
|
Code Climate has analyzed commit e4643ba and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 88.4% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.1% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1/2
main<- this <- #3570Part of #3222
This PR handles
dvc plotsdiff throwing an error. The error is displayed in the plots tree. In the normal way that we display "global errors". I will delay the 2nd part of this PR (displaying global errors in the webview) until #3523 is merged.Demo
Screen.Recording.2023-03-28.at.1.09.30.pm.mov
Note:
dvc plots diffwill actually no longer throw an error under the above circumstances.