Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that data for broken revisions is dropped #3576

Merged
merged 1 commit into from
Apr 2, 2023

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Mar 28, 2023

1/2 main <- this <- #3578

#3532 introduced a bug where completely broken revisions would be incorrectly retained in the partial cache. This PR ensures that the data for broken revisions is dropped (highlighted in the live demo this morning cc @dberenbaum).

Demo

Screen.Recording.2023-03-29.at.10.32.43.am.mov

This again highlights that we need further error messages for broken revisions.

@mattseddon mattseddon added the bug Something isn't working label Mar 28, 2023
@mattseddon mattseddon self-assigned this Mar 28, 2023
@mattseddon mattseddon changed the base branch from main to show-ribbon-errors March 28, 2023 23:35
@mattseddon mattseddon marked this pull request as ready for review March 28, 2023 23:36
@mattseddon mattseddon force-pushed the ensure-missing-dropped branch from e49f021 to ffb69fa Compare March 29, 2023 02:13
Copy link
Contributor

@julieg18 julieg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mattseddon mattseddon force-pushed the show-ribbon-errors branch from 307684e to 606851a Compare April 2, 2023 07:54
Base automatically changed from show-ribbon-errors to main April 2, 2023 08:21
@mattseddon mattseddon force-pushed the ensure-missing-dropped branch from ffb69fa to f28d2d1 Compare April 2, 2023 09:05
@mattseddon mattseddon enabled auto-merge (squash) April 2, 2023 09:07
@codeclimate
Copy link

codeclimate bot commented Apr 2, 2023

Code Climate has analyzed commit f28d2d1 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.1% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit 4964ea6 into main Apr 2, 2023
@mattseddon mattseddon deleted the ensure-missing-dropped branch April 2, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants