Ensure that data for broken revisions is dropped #3576
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1/2
main
<- this <- #3578#3532 introduced a bug where completely broken revisions would be incorrectly retained in the partial cache. This PR ensures that the data for broken revisions is dropped (highlighted in the live demo this morning cc @dberenbaum).
Demo
Screen.Recording.2023-03-29.at.10.32.43.am.mov
This again highlights that we need further error messages for broken revisions.