Update custom plot spec #3634
Update custom plot spec #3634
Conversation
* have metric vs param plot use scatter plot
| } | ||
| } | ||
| ] | ||
| mark: { |
There was a problem hiding this comment.
I went with a scatter plot for now, but there was some discussion on what plot to use in #3373. Other options we could use are in demos there.
|
@dberenbaum do you remember why we use non filled shape (circle) for the scatter plot template - it might be more visible / readable to fill them, wdyt? |
| } | ||
| } | ||
| }) | ||
| } as CustomPlotsData |
| calculate: "format(datum['y'],'.5f')" | ||
| filled: true, | ||
| size: 60, | ||
| type: 'point' |
There was a problem hiding this comment.
Turns out just filling point or using circle make the marks even smaller:
I ended up increasing the size so that the filled points would have a similar width to none filled points:
|
Code Climate has analyzed commit d150f2a and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 94.8% (0.0% change). View more on Code Climate. |
Demo
https://user-images.githubusercontent.com/43496356/229911951-9abe154b-3fd2-4145-a9e6-0baaa748e980.movScreen.Recording.2023-04-05.at.9.30.27.AM.mov
To Do
Part of #3373