Remove checkpoints from experiment collection #3639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
commented
Apr 5, 2023
| @@ -1,6 +1,4 @@ | |||
| import { collectExperiments } from './collect' | |||
| import { Experiment } from '../webview/contract' | |||
| import modifiedFixture from '../../test/fixtures/expShow/modified/output' | |||
There was a problem hiding this comment.
[F] No longer needed at all.
mattseddon
force-pushed
the
remove-checkpoints-from-collection
branch
from
d78dd92 to
df3f864
Compare
sroy3
approved these changes
Apr 5, 2023
mattseddon
force-pushed
the
remove-checkpoints-from-collection
branch
from
df3f864 to
879ccdc
Compare
mattseddon
force-pushed
the
remove-checkpoints-from-collection
branch
from
d74fb97 to
be13cbe
Compare
|
Code Climate has analyzed commit be13cbe and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 95.6% (85% is the threshold). This pull request will bring the total coverage in the repository to 94.9% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1/2
main<- this <- #3641This PR removes checkpoints from experiment collection. I have not thoroughly cleaned the code as it parts of it will be rewritten as we integrate the new format.