Combine/enhance commands used to stop experiments #3840
Conversation
mattseddon
force-pushed
the
fix-stop-options
branch
from
28ad143 to
4bfefa4
Compare
mattseddon
force-pushed
the
fix-stop-options
branch
2 times, most recently
from
22e33eb to
176acdf
Compare
|
|
||
| await collectDvcRootPids(pids, dvcRoot) | ||
|
|
||
| const [pid] = [...pids] |
There was a problem hiding this comment.
How about const pid = pids.slice(0, 1)? It doesn't matter one or the other, I guess it's just a preference, but to me it looks like 2 steps vs. one.
There was a problem hiding this comment.
I would still have to convert the set into an array (error TS2339: Property 'slice' does not exist on type 'Set<number>'). Whatever I do it will look a bit whacky. This comment did make me realise that I needed another logic branch "to be safe". Thanks
There was a problem hiding this comment.
I get it now. I thought you were avoiding mutation, I didn't follow to see it was a Set, my bad. Thanks for explaining.
| @@ -362,8 +362,8 @@ | |||
| "category": "DVC" | |||
There was a problem hiding this comment.
Not sure if it's just an issue on my end, but when I tried to stop all experimentts when both queed and workspace experiments were running, the plots would fail with an error like:
plots diff adunc-mash mousy-hack terse-scut finer-linn b950796 -o .dvc/tmp/plots --split --json failed with ERROR: unknown Git revision 'adunc-mash'
trim.mov
There was a problem hiding this comment.
Ah, wait looks like this bug is getting fixed in #3846 :)
mattseddon
force-pushed
the
fix-stop-options
branch
from
83c2878 to
2a21262
Compare
|
Code Climate has analyzed commit 2a21262 and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 91.4% (85% is the threshold). This pull request will bring the total coverage in the repository to 94.8% (0.0% change). View more on Code Climate. |
3/3
main<- #3832 <- #3834 <- thisThis PR consolidates our "Stop Experiment" commands. There is now no external separation between stopping an experiment running in the workspace or queue. Experiments can now be stopped via an inline action shown in the experiments tree, the tree's view/title, the experiments table context menu, the editor/title and the command palette.
Demo
Screen.Recording.2023-05-09.at.2.41.44.pm.mov
Screen.Recording.2023-05-09.at.2.42.17.pm.mov
Screen.Recording.2023-05-09.at.4.06.48.pm.mov
Screen.Recording.2023-05-09.at.3.03.08.pm.mov